Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
49a5c97
feat(scene): make removeFromScene symmetric with addToScene
RaananW Jun 29, 2026
395b417
fix(api-report): treat parameter-type widening as non-breaking
RaananW Jun 29, 2026
8fc7772
Merge remote-tracking branch 'origin/master' into raananw-symmetric-r…
RaananW Jun 29, 2026
b564851
fix(scene): address Copilot review on removeFromScene
RaananW Jun 29, 2026
6a57305
Merge remote-tracking branch 'origin/master' into raananw-symmetric-r…
RaananW Jul 1, 2026
f62548d
chore(bundle): regenerate per-scene manifests after master merge
RaananW Jul 1, 2026
570b07a
Restore bundle manifests to master (regen was measurement noise; fix …
RaananW Jul 1, 2026
f46cdd2
Update scene129/scene173 manifests for removeFromScene growth (+1.0KB…
RaananW Jul 1, 2026
5e0e2b5
Compact removeFromScene to shrink non-mesh dispatch (~0.2KB/scene)
RaananW Jul 1, 2026
5f704e4
Update bundle manifests to fix stale validate-bundle-manifest check
RaananW Jul 1, 2026
bbc3062
Merge remote-tracking branch 'origin/master' into raananw-symmetric-r…
RaananW Jul 2, 2026
bd04c01
Correct removeFromScene-affected manifests after master merge
RaananW Jul 2, 2026
266b66e
Merge master
ryantrem Jul 13, 2026
9dcbd4b
Merge remote-tracking branch 'origin/master' into raananw-symmetric-r…
RaananW Jul 14, 2026
4339011
chore(bundle): rebaseline scene129/173/223 manifests after master merge
RaananW Jul 14, 2026
4d61bdd
feat(scene): tie removeFromScene signature to addToScene via overload
RaananW Jul 15, 2026
f2c8d60
refactor(scene): guard removeFromScene/addToScene symmetry via zero-c…
RaananW Jul 15, 2026
efb2882
Merge remote-tracking branch 'origin/master' into raananw-symmetric-r…
RaananW Jul 15, 2026
9c56d5b
chore(bundle): rebaseline PBR scene manifests after merging master #397
RaananW Jul 15, 2026
96b5bfe
Merge remote-tracking branch 'origin/master' into raananw-symmetric-r…
ryantrem Jul 17, 2026
6d93460
chore(bundle): rebaseline scene205 manifest (gzip 25->26 KB)
ryantrem Jul 17, 2026
136c959
Merge remote-tracking branch 'origin/master' into raananw-symmetric-r…
RaananW Jul 17, 2026
5ea2473
chore(bundle): rebaseline scene129 manifest (85.5->85.4 KB) after mas…
RaananW Jul 17, 2026
5f0ce32
Merge remote-tracking branch 'origin/master' into raananw-symmetric-r…
RaananW Jul 17, 2026
70b3bba
chore(bundle): rebaseline scene11/174/242/265 manifests after master …
RaananW Jul 17, 2026
ea6b014
Merge remote-tracking branch 'origin/master' into raananw-symmetric-r…
RaananW Jul 17, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docs/lite/architecture/01-scene.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,10 @@ export interface SceneContext {
}

/** Add an entity or asset container to the scene. Auto-routes by type. */
export function addToScene(scene: SceneContext, entity: Mesh | LightBase | ShadowGenerator | TransformNode | AssetContainer): void;
export function addToScene(scene: SceneContext, entity: Mesh | LightBase | Camera | ShadowGenerator | TransformNode | AssetContainer): void;

/** Remove an entity or asset container from the scene, undoing addToScene. Idempotent. */
export function removeFromScene(scene: SceneContext, entity: Mesh | LightBase | Camera | ShadowGenerator | TransformNode | AssetContainer): void;

/** Register a callback to run before each rendered frame. */
export function onBeforeRender(scene: SceneContext, cb: (deltaMs: number) => void): void;
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene101.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 53.6,
"rawKB": 53.7,
"gzipKB": 21.4,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene105.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 102.2,
"rawKB": 102.3,
"gzipKB": 39.5,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene11.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"rawKB": 89,
"gzipKB": 37.4,
"gzipKB": 37.5,
"ignoredRawKB": 0,
"runtimeChunks": [
"scene11-create-skeleton-D-3exD5E.js",
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene118.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 76.5,
"rawKB": 76.6,
"gzipKB": 30.4,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene12.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"rawKB": 103.7,
"gzipKB": 42.3,
"gzipKB": 42.4,
"ignoredRawKB": 0,
"runtimeChunks": [
"scene12-create-skeleton-yE34pa8K.js",
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene127.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 61.1,
"rawKB": 61.2,
"gzipKB": 23.5,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
4 changes: 2 additions & 2 deletions lab/public/bundle/manifest/scene129.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"rawKB": 84.9,
"gzipKB": 32.3,
"rawKB": 85.6,
"gzipKB": 32.5,
"ignoredRawKB": 0,
"runtimeChunks": [
"scene129-gs-picking-pipeline-RhdQBaXc.js",
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene14.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"rawKB": 88.3,
"gzipKB": 36.9,
"gzipKB": 37,
"ignoredRawKB": 0,
"runtimeChunks": [
"scene14-background-dds-skybox-3VCqz2Ti.js",
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene144.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 112.3,
"rawKB": 112.4,
"gzipKB": 45.7,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene15.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"rawKB": 47.3,
"gzipKB": 18.8,
"gzipKB": 18.9,
"ignoredRawKB": 0,
"runtimeChunks": [
"scene15-standard-renderable-cgZZ-rj3.js",
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene150.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 55.1,
"rawKB": 55.2,
"gzipKB": 21.5,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene155.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 57.7,
"rawKB": 57.8,
"gzipKB": 22.4,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene160.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 41.7,
"rawKB": 41.8,
"gzipKB": 16.3,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene161.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 40.3,
"rawKB": 40.4,
"gzipKB": 15.8,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene172.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 59.7,
"rawKB": 59.8,
"gzipKB": 23.4,
"ignoredRawKB": 1485.2,
"runtimeChunks": [
Expand Down
4 changes: 2 additions & 2 deletions lab/public/bundle/manifest/scene173.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"rawKB": 62.7,
"gzipKB": 24.3,
"rawKB": 63.4,
"gzipKB": 24.6,
"ignoredRawKB": 1485.2,
"runtimeChunks": [
"scene173-recast-navigation-CYBQI-zY-Dry_z7x_.js",
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene174.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"rawKB": 96.3,
"gzipKB": 39.4,
"gzipKB": 39.5,
"ignoredRawKB": 1485.2,
"runtimeChunks": [
"scene174-generate-mipmaps-CU0CttiE.js",
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene178.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 87.8,
"rawKB": 87.9,
"gzipKB": 35.8,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene2.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 46.9,
"rawKB": 47,
"gzipKB": 18.7,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene202.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 49.3,
"rawKB": 49.4,
"gzipKB": 20,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene205.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 62.1,
"rawKB": 62.2,
"gzipKB": 25.5,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene207.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"rawKB": 59.7,
"gzipKB": 23.9,
"gzipKB": 24,
"ignoredRawKB": 0,
"runtimeChunks": [
"scene207-_mat4-storage-f64-B_0HYOAx.js",
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene21.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"rawKB": 85.7,
"gzipKB": 35,
"gzipKB": 35.1,
"ignoredRawKB": 0,
"runtimeChunks": [
"scene21-background-hdr-skybox-BJiEFB7s.js",
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene210.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 76.9,
"rawKB": 77,
"gzipKB": 32,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene211.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 90.8,
"rawKB": 90.9,
"gzipKB": 38.4,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene213.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 50,
"rawKB": 50.1,
"gzipKB": 19.4,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene218.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 94.7,
"rawKB": 94.8,
"gzipKB": 39.3,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene22.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 97.6,
"rawKB": 97.7,
"gzipKB": 39.5,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene222.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 118.4,
"rawKB": 118.5,
"gzipKB": 43.9,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
4 changes: 2 additions & 2 deletions lab/public/bundle/manifest/scene223.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"rawKB": 64.4,
"gzipKB": 24.4,
"rawKB": 65.2,
"gzipKB": 24.6,
"ignoredRawKB": 0,
"runtimeChunks": [
"scene223-standard-renderable-W0J5Mh6Q.js",
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene224.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 81.9,
"rawKB": 82,
"gzipKB": 30.4,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene225.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 58,
"rawKB": 58.1,
"gzipKB": 23.3,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene227.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 48.2,
"rawKB": 48.3,
"gzipKB": 19.1,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene242.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 97.4,
"rawKB": 97.5,
"gzipKB": 40.4,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene243.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 97.6,
"rawKB": 97.7,
"gzipKB": 41.2,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene244.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"rawKB": 133.7,
"gzipKB": 54.2,
"gzipKB": 54.3,
"ignoredRawKB": 0,
"runtimeChunks": [
"scene244-animation-pointer-ext-C4AEJP3o.js",
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene25.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 51.9,
"rawKB": 52,
"gzipKB": 20.6,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene251.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 89.8,
"rawKB": 89.9,
"gzipKB": 37.1,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene258.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 83,
"rawKB": 83.1,
"gzipKB": 34.9,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene259.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"rawKB": 77.2,
"gzipKB": 32,
"gzipKB": 32.1,
"ignoredRawKB": 0,
"runtimeChunks": [
"scene259-emissive-fragment-DxwEm_rR.js",
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene26.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 89.8,
"rawKB": 89.9,
"gzipKB": 36.6,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene265.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"rawKB": 80,
"gzipKB": 33.4,
"gzipKB": 33.5,
"ignoredRawKB": 0,
"runtimeChunks": [
"scene265-generate-mipmaps-B94XvMrD.js",
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene3.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 53.7,
"rawKB": 53.8,
"gzipKB": 21.5,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene30.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"rawKB": 103.7,
"gzipKB": 42.9,
"gzipKB": 43,
"ignoredRawKB": 0,
"runtimeChunks": [
"scene30-alpha-test-fragment-CbD6ycHo.js",
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene38.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 61.1,
"rawKB": 61.2,
"gzipKB": 24.1,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene4.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 72.5,
"rawKB": 72.6,
"gzipKB": 28.5,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene40.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 49.6,
"rawKB": 49.7,
"gzipKB": 19.9,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene42.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 51.2,
"rawKB": 51.3,
"gzipKB": 20.3,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene48.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"rawKB": 54.4,
"gzipKB": 21.5,
"gzipKB": 21.6,
"ignoredRawKB": 0,
"runtimeChunks": [
"scene48-standard-renderable-B82OV5q4.js",
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene6.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 72.4,
"rawKB": 72.5,
"gzipKB": 30.3,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene70.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 90.7,
"rawKB": 90.8,
"gzipKB": 36.7,
"ignoredRawKB": 14.9,
"runtimeChunks": [
Expand Down
2 changes: 1 addition & 1 deletion lab/public/bundle/manifest/scene75.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"rawKB": 50.2,
"rawKB": 50.3,
"gzipKB": 20,
"ignoredRawKB": 0,
"runtimeChunks": [
Expand Down
Loading
Loading