Configurable test timeouts, with higher timeout for splat loading#405
Open
ryantrem wants to merge 2 commits into
Open
Configurable test timeouts, with higher timeout for splat loading#405ryantrem wants to merge 2 commits into
ryantrem wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes bundle-size measurement timeouts configurable per scene to reduce CI flakiness, specifically increasing the “wait for canvas.dataset.ready” budget for the Gaussian Splatting GPU-picking scene that is slow under SwiftShader.
Changes:
- Introduces a default “ready” timeout (50s) plus per-scene overrides (scene129 → 150s).
- Plumbs the per-scene ready timeout into
measurePageand improves the timeout error message to reflect the configured budget.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The catch around page.waitForFunction previously swallowed any error and reported it as a timeout, hiding real failures (page crash, execution context destroyed, navigation failure) behind a misleading 'timed out' message. Capture the error and rethrow unless Playwright actually raised a TimeoutError. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2ba531c3-05f4-4264-a768-2b867ff61d7d
Lab - Static SiteBuild 20260711.5 - merge @ c335f0c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scene129 is frequently timing out, seemingly because swift shader is slow on CI machines. Trying out increasing timeout to reduce flakiness.