Open
Conversation
Add serialize-javascript override (>=7.0.5) to resolve high-severity RCE and DoS advisories. Run npm audit fix for remaining non-breaking updates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Tests npm dependencies to eliminate reported npm audit vulnerabilities, primarily by forcing a patched serialize-javascript version and refreshing the lockfile with non-breaking fixes.
Changes:
- Add an npm
overridesentry to forceserialize-javascript >= 7.0.5. - Update
Tests/package-lock.jsonvianpm audit fixto pick up patched transitive dependency versions.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Tests/package.json | Adds an overrides rule to remediate serialize-javascript advisories. |
| Tests/package-lock.json | Updates resolved dependency graph to patched versions and reflects the serialize-javascript override. |
Files not reviewed (1)
- Tests/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Mocha's serialize-javascript vulnerability is not exploitable in this context (test bundling only). Keeping just the non-breaking npm audit fixes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Created by Copilot on behalf of @bghgary]
Fix npm audit vulnerabilities in the test project.
Changes
package-lock.json: Updated bynpm audit fixfor all non-breaking vulnerability fixes (ajv, brace-expansion, diff, glob, js-yaml, minimatch, picomatch, webpack).Before: 11 vulnerabilities (2 low, 3 moderate, 6 high)
After: 2 vulnerabilities (2 high — both from mocha's
serialize-javascriptdependency, not exploitable in this context since it's only used for test bundling)Supersedes #134.