[codex] Port remaining Android XR compatibility fixes#182
Open
matthargett wants to merge 1 commit into
Open
Conversation
91cf1ad to
625af30
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Android unit test harness and related dependencies to newer Android tooling (API 35 / newer NDK), improves Android-native logging, and adds compatibility for different V8 Inspector connect() signatures.
Changes:
- Bumped Android compile/target SDK to 35, updated NDK version handling, and improved ABI filter selection logic.
- Switched native test trace output to Logcat and updated Android emulator CI to API level 35.
- Updated JSC Android dependency and adjusted V8 Inspector agent for V8 version API differences.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/UnitTests/Android/app/src/main/cpp/JNI.cpp | Routes debug trace output to Android Logcat instead of stdout. |
| Tests/UnitTests/Android/app/build.gradle | Updates SDK/NDK configuration and refines ABI filter behavior. |
| README.md | Updates Android setup instructions to match new SDK/NDK/API level expectations. |
| Core/Node-API/package-jsc.json | Bumps jsc-android dependency version. |
| Core/AppRuntime/V8Inspector/Source/V8InspectorAgent.cpp | Adds V8 version-based connect() handling and adjusts string buffer creation. |
| .github/workflows/build-android.yml | Moves CI emulator image to API level 35. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
24a1874 to
f41030f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR now contains only the Android/runtime-host work that is still missing from
mainafter rebasing onto8cd1429:-PndkVersionoverride;JsRuntimeHostlogcat tag; andchar16_t/uint16_ttype-punning buffer with a correctly typedstd::vector<uint16_t>.The Android setup instructions now name the SDK and NDK versions required by this test configuration.
Work already superseded or removed
70ba1e5) already made the project build with NDK r28c and moved Android CI to it. #159 (49e2980) migrated CI to GitHub Actions, and #164 (7239f91) restored the connected-emulator test. This PR therefore only advances that emulator from API 33 to API 35 and aligns the local Gradle default.06d4420) aligned the supported Android and Windows prebuilts on V8 11. The old three-argument/four-argument inspectorconnectsplit is no longer applicable and has been removed from this PR.android-jsc250231.0.0->294992.0.0bump has been removed.294992is published under a different Maven path than this repository consumes, and its arm64 binary still has 4 KiB ELF load alignment, so it would not solve Android 15/Android XR 16 KiB page compatibility. #206 handles the replacement separately by consuming Bun's pinned Android WebKit/JSC archives forarm64-v8aandx86_64, relinking them aslibjsc.so, and raising only the JSC path to API 28.f07d991) was resolved while preserving its Hermes and host-compiler CMake arguments.Validation
npm ciinTests.28.2.13676358arm64 debug builds with both V8 and JavaScriptCore.libc++_shared.so, and the supported V8 prebuilt all use 16 KiB load alignment. The legacy JSC prebuilt validated by this branch remains 4 KiB aligned; its intentionally separate replacement in #206 produces 16 KiB-alignedlibjsc.sobinaries forarm64-v8aandx86_64.git diff --check.Scope
This is Android API/toolchain and runtime-host preparation; it is not by itself complete BabylonNative Android XR support. OpenXR loader/manifest wiring, lifecycle and input integration, arm64 Android CI/ELF auditing, and validation on Galaxy XR/XREAL hardware remain separate follow-up work (principally BabylonNative#1766).