Wifi shutdown timeout and prepare for release v3.0.15 #4402
+34
−232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several changes aimed at improving Wi-Fi synchronization and preparing for a new release. The memory allocations for the heap and network buffers have been increased, while the audio buffer has been reduced, likely for memory optimization and performance tuning. A significant improvement is the addition of a timeout when turning off the Wi-Fi module, which enhances the system's robustness by preventing potential deadlocks. My review includes a suggestion to improve this timeout mechanism by using a for loop and adding logging for when the timeout is hit, which will be valuable for debugging.
TuEmb
force-pushed
the
TuEmb/wifi_improv
branch
from
5af7776 to
ee74f02
Compare
TuEmb
force-pushed
the
TuEmb/wifi_improv
branch
from
512ab9a to
a699dbe
Compare
TuEmb
changed the title
Contributor
Author
|
Collaborator
|
lgtm @TuEmb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted #4402 and #4190 --> the cause of bricked devices
Reverted #4372 --> bring the long press feature back
Release check list:
Power Consumption Profile:
Offline Mode:
Live Mode:
BLE Sync Mode:
Deepsleep Mode:
