fix: handle Safari View Controller launch failures in app detail page #4433
Conversation
Wrap launchUrl calls with inAppBrowserView in try-catch to prevent crashes when Safari View Controller fails to load. Falls back to external browser mode, then shows user-friendly error message. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively fixes a crash related to URL launching by implementing a robust _launchUrlSafely helper with fallback mechanisms and error handling. The refactoring to use this helper throughout the code is clean. However, there's a significant localization issue: the new error message string couldNotOpenUrl has been added to all language files with an English value, instead of being translated. This needs to be corrected to ensure a consistent user experience across all supported languages.
app/lib/l10n/app_ar.arb
Outdated
| "applyFilters": "تطبيق الفلاتر", | ||
| "mostInstalls": "الأكثر تثبيتاً" | ||
| "mostInstalls": "الأكثر تثبيتاً", | ||
| "couldNotOpenUrl": "Could not open URL. Please try again." |
There was a problem hiding this comment.
The new localization key couldNotOpenUrl has an English value. This needs to be translated into Arabic. This issue is present across all the non-English .arb files updated in this pull request, and they should all be updated with their respective translations.
Summary
_launchUrlSafelyhelper that catchesPlatformExceptionand falls back to external browsercouldNotOpenUrllocalization key for error messageTest plan
🤖 Generated with Claude Code