fix(core): fail closed on RPD counter errors#79
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Bayashat <baiashat2002@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π Description
What: fail closed when the bot or quiz Gemini RPD counter cannot be atomically updated in DynamoDB, and map that condition to existing provider-unavailable handling before any Gemini request is made.
Why: the previous ClientError path returned
(0, True), which let production traffic bypass the daily RPD quota if DynamoDB throttled, IAM/table configuration broke, or the counter table was temporarily unavailable.Verification:
python3 -m compileall -q src tests/test_rate_limit_fail_closed.pypython3 -m pytest tests/test_rate_limit_fail_closed.py(4 passed)π Type of Change
ποΈ Infrastructure Changes (Crucial)
β Checklist
pre-commit run --all-fileslocally and fixed all issues.pytest).cdk difflocally to verify changes.π Related Issues