fix: use noreply@ as From address for forum and group notifications - #467
Closed
Neophytis wants to merge 270 commits into
Closed
fix: use noreply@ as From address for forum and group notifications#467Neophytis wants to merge 270 commits into
Neophytis wants to merge 270 commits into
Conversation
…llow comments with email addresses.
…f applicable. Sort translations correctly. Show/hide password.
* Add check for phone number in CommentModel * Add check for phone number in CommentController * Add anti-spam check in RelationsController Added functions to check for email address and phone number, and only add the comment if none are detected
…ved to spam on block word.
…nd make forum work with strict mode for DB.
* Add browser push infrastructure * Add browser push subscription preference * Wire browser push notification delivery * Add browser push data cleanup and export * Test browser push notifications * Add browser notification modes * Harden browser notification polling * Harden browser push notifications Validate endpoint ownership and VAPID configuration, make migrations and queue leases safe, and reconcile subscriptions across preference and logout transitions. Align retention, member exports, privacy copy, and regression coverage with the stored push data. Refs #168 * Remove minishlink prefix * Address browser push review feedback
…n prod (#459) Stale compiled Symfony DI containers (from a persistent var/ volume) can reference renamed or removed classes — causing doctrine:migrations:migrate to crash with 'class not found' before cache:clear ever runs. Moving cache:clear to before migrations ensures the DI container is always freshly compiled from the current image's config before migrations execute. The duplicate cache:clear in the prod else-branch is removed accordingly.
Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) from 7.12.3 to 7.15.2. - [Release notes](https://github.com/guzzle/guzzle/releases) - [Changelog](https://github.com/guzzle/guzzle/blob/7.15.2/CHANGELOG.md) - [Commits](guzzle/guzzle@7.12.3...7.15.2) --- updated-dependencies: - dependency-name: guzzlehttp/guzzle dependency-version: 7.15.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix admin rights member lists * fix AdminRightControllerTest * preserve rights history and locations * Migrate admin rights and flags to Symfony
forum@ and group@ were hardcoded in SendAndPushNotificationsCommand, causing member replies to land in the OTRS raw queue. Inject both addresses via DI so they pick up the env var and default to noreply@. Update .env defaults and add MAILER_FORUM_ADDRESS so all three notification From addresses (message, forum, group) resolve to noreply@bewelcome.org, which has a Mailcow Sieve auto-reply configured.
Contributor
Author
|
Closing — incorrectly branched from develop. Reopening from master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forum@bewelcome.organdgroup@bewelcome.orgwere hardcoded inSendAndPushNotificationsCommand::determineSender(), causing member replies to land in the OTRS raw queuenoreply@bewelcome.org)MAILER_FORUM_ADDRESSenv var; update.envdefaults forMAILER_MESSAGE_ADDRESSandMAILER_GROUP_ADDRESStonoreply@bewelcome.orgnoreply@bewelcome.orghas a Mailcow Sieve vacation script configured that auto-replies: "This mailbox is not monitored."Changes
src/Command/SendAndPushNotificationsCommand.php$forumEmailAddressand$groupEmailAddressvia DI; remove hardcoded strings.envMAILER_MESSAGE_ADDRESS,MAILER_GROUP_ADDRESS,MAILER_FORUM_ADDRESStonoreply@bewelcome.orgconfig/services.yaml$forumEmailAddressbindingTest plan
Fromheader isnoreply@bewelcome.orgFromheader isnoreply@bewelcome.org