fix: use noreply@ as From address for forum and group notifications - #468
Closed
Neophytis wants to merge 1 commit into
Closed
fix: use noreply@ as From address for forum and group notifications#468Neophytis wants to merge 1 commit into
Neophytis wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing to investigate master properly before opening a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forum@bewelcome.organdgroup@bewelcome.orgwere hardcoded as theFromaddress inSendNotificationsCommand::determineSender(). Member replies to these notifications were landing in the OTRS raw queue.Changed both to
noreply@bewelcome.org, which has a Mailcow Sieve auto-reply configured that responds: "This mailbox is not monitored."Changes
1 file, 2 lines changed in
src/Command/SendNotificationsCommand.php.Test plan
Fromheader showsnoreply@bewelcome.org