fix(mailer): use noreply@bewelcome.org as From to pass DMARC - #471
Merged
thisismeonmounteverest merged 1 commit intoAug 5, 2026
Merged
Conversation
Contact form submissions from Yahoo/Gmail/Outlook users were silently rejected by Mailcow (score 31+/15) because Rspamd enforces DMARC policy. When Lion relays with From: user@yahoo.fr, SPF and DKIM both fail for yahoo.fr → DMARC p=reject triggers. Fix: sendFeedbackEmail and sendCommentReportedFeedbackEmail now send with From: noreply@bewelcome.org (which Lion is authorised to sign) and add Reply-To: <reporter> so staff can still reply directly to the user. Also adds the reporter email to the feedback email body so Znuny can attribute the ticket correctly after the From change. Adds unit tests covering From/Reply-To headers for both methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contact form submissions from Yahoo/Gmail/Outlook users were silently rejected by Mailcow (score 31+/15) because Rspamd enforces DMARC policy. When Lion relays with From: user@yahoo.fr, SPF and DKIM both fail for yahoo.fr → DMARC p=reject triggers.
Fix: sendFeedbackEmail and sendCommentReportedFeedbackEmail now send with
From: noreply@bewelcome.org (which Lion is authorised to sign) and add
Reply-To: so staff can still reply directly to the user.
Also adds the reporter email to the feedback email body so Znuny can attribute the ticket correctly after the From change.
Adds unit tests covering From/Reply-To headers for both methods.