-
Notifications
You must be signed in to change notification settings - Fork 97
Closes #5272: alignment tests for arkouda.numpy.pdarraysetops #5274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #5272: alignment tests for arkouda.numpy.pdarraysetops #5274
Conversation
68918e2 to
26838e5
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5274 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 45
Lines ? 1424
Branches ? 0
========================================
Hits ? 1424
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
26838e5 to
3d0ef27
Compare
24f8c35 to
bacab0b
Compare
1RyanK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too worried about the comments but I figure it could be a while before someone comes back to this test and this might make things simpler...?
644bfe1 to
ab542aa
Compare
Add NumPy alignment test suite for pdarray set operations
Summary
This PR adds a comprehensive NumPy-alignment test suite for Arkouda pdarray set operations, covering:
in1dunion1dintersect1dsetdiff1dsetxor1dconcatenateindexof1dThe goal is to explicitly verify semantic alignment with NumPy behavior and to surface existing deviations in a controlled, well-documented way.
What’s included
tests/numpy/alignment_verification/pdarraysetops_alignment.pypytest.iniso the suite runs as part of standard alignment verification.assume_unique=Truecases:Known issues (documented via xfail)
ak.union1ddoes not match NumPy semantics when one input is empty.xfailand linked to Issue Bug:ak.union1dnot NumPy-aligned for empty-input cases (returns non-unique / unsorted) #5273, so the suite remains informative but non-blocking.Why this matters
assume_unique) from real semantic gaps in Arkouda.Follow-up work
ak.union1dempty-input fast paths to applyunique + sort.xfails once behavior matches NumPy.Testing
xfails.Closes #5272: alignment tests for arkouda.numpy.pdarraysetops