Closes #5413: bug in pd.array when dtype is ak.bigint#5414
Open
ajpotts wants to merge 1 commit intoBears-R-Us:mainfrom
Open
Closes #5413: bug in pd.array when dtype is ak.bigint#5414ajpotts wants to merge 1 commit intoBears-R-Us:mainfrom
ajpotts wants to merge 1 commit intoBears-R-Us:mainfrom
Conversation
318a138 to
7d218a9
Compare
7d218a9 to
778f511
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where constructing a pandas
ExtensionArrayfrom anexisting Arkouda
bigintpdarrayusing:would incorrectly attempt a server-side cast:
which fails because Arkouda does not support casting
biginttoobject.Root Cause
Inside
ArkoudaArray._from_sequence, when pandas passed anArkoudaBigintDtype, the implementation converted it to its NumPyequivalent (
object).This caused:
ak.array(existing_bigint_pdarray, dtype=object)ak.cast(..., object)cast<bigint,object,1>Fix
Special-case
ArkoudaBigintDtypein_from_sequenceso that:"bigint"is passed directly toak.arrayobjectoccursAll other Arkouda dtypes continue to use their NumPy equivalents as
before.
Test Coverage
Adds regression test:
This test verifies:
This would have failed prior to this fix with a
RuntimeError.Impact
ak.bigintdtype constructionCloses #5413: bug in pd.array when dtype is ak.bigint