Add conversion to/from gleam types for CBOR tags 1-4#8
Open
karlsson wants to merge 1 commit intoBeaudidly:mainfrom
Open
Add conversion to/from gleam types for CBOR tags 1-4#8karlsson wants to merge 1 commit intoBeaudidly:mainfrom
karlsson wants to merge 1 commit intoBeaudidly:mainfrom
Conversation
Owner
|
@karlsson Something I was thinking about is if we want to configure the decode process, and potentially the encoding part. For decoding, that could look like:
Encoding:
|
Author
|
Yes, and concerning tags 2 and 3 (Bignum) they are automatically handled by Erlang integers, but for javascript I think you need BigInt which is handled by the gleam library |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will decode time tags (1,2) and bignum (3,4) to gleam Timestamp (gleam_time type) and Int respectively. It will also encode Timestamps to tag 0 (only) and bignum integers to tag 3 or 4.
This is a proposal that may need some more thought and should maybe not be included the 1.0 release?