Draft
Conversation
Owner
Benjamin-Philip
commented
May 21, 2023
Benjamin-Philip
commented
- Add from_erlang/2 to serde_arrow_buffer
- Add to_arrow/2
- Add to_arrow docs
- Add to_erlang/1
- Store binary data as a single binary in a buffer
- Add incomplete implementation of from_arrow
Owner
Author
|
This PR will be rebased to main once main has the necessary features to full implement this function. Till then, this PR simply serves as a way to save any progress I have made with this function. |
josevalim
approved these changes
May 21, 2023
This commits adds tests and an incomplete of from_arrow. Right now, it can manage assigning a type, and length to the buffer, but is unable to deserialize the actual data from arrow. This is because we also need a validity bitmap to deserialize data, something which a buffer doesn't have.
Benjamin-Philip
force-pushed
the
bp-buffer-from-arrow
branch
from
bc944ac to
600ed35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.