🎨 Palette: Improved login accessibility and error handling#19
🎨 Palette: Improved login accessibility and error handling#19BenjaminWie wants to merge 1 commit intomainfrom
Conversation
- Replaced browser alert() with inline error message in LoginView. - Added screen-reader-only label for email input. - Implemented aria-invalid, aria-describedby, and role="alert" for better accessibility. - Added aria-hidden="true" to decorative logo SVG. - Ensured error messages are cleared when the user starts typing. - Updated .gitignore to exclude pnpm-lock.yaml and preview.log. Co-authored-by: BenjaminWie <54136562+BenjaminWie@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c92b436cfc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (externalError !== prevExternalError) { | ||
| setError(externalError || ''); | ||
| setPrevExternalError(externalError); |
There was a problem hiding this comment.
Updating state during render (setError/setPrevExternalError) is not supported in React and can cause repeated renders or warnings in Strict/Concurrent mode when externalError changes. This sync should happen in a useEffect watching externalError; otherwise every prop change triggers a render-time state update which can lead to unstable behavior under React 18’s double-invocation rendering.
Useful? React with 👍 / 👎.
1 participant
This PR introduces a micro-UX improvement to the login flow:
.gitignoreto keep the repository clean of temporary files and lockfiles.PR created automatically by Jules for task 5262337850652406314 started by @BenjaminWie