🎨 Palette: Improve Login Form Accessibility and Error Handling#21
🎨 Palette: Improve Login Form Accessibility and Error Handling#21BenjaminWie wants to merge 1 commit intomainfrom
Conversation
- Replaced browser alert() with accessible inline error messages in the login flow. - Implemented derived state pattern in LoginView to sync external error props. - Added visually hidden <label> for the email input. - Added aria-invalid, aria-describedby, and role="alert" for better screen reader support. - Recorded UX learnings in .Jules/palette.md. Co-authored-by: BenjaminWie <54136562+BenjaminWie@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef6932a4b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id="email-input" | ||
| type="email" | ||
| value={email} | ||
| onChange={(e) => { setEmail(e.target.value); setError(''); }} |
There was a problem hiding this comment.
Clearing only the local error here breaks repeat failure feedback: after one rejected login, typing in the field removes the message, and a second rejected login with the same backend message often won't reappear because the parent loginError value is unchanged and the prop-sync guard (externalError !== prevExternalError) never runs. In that flow, users can keep getting denied without seeing any error text.
Useful? React with 👍 / 👎.
1 participant
This PR introduces a micro-UX improvement to the login flow by replacing disruptive browser alerts with accessible, inline validation messages.
💡 What:
App.tsxto manage login errors via state.LoginView.tsxwith a semantic<label>(visually hidden viasr-only).aria-invalidandaria-describedbyto the email input for robust accessibility.role="alert"on error messages to ensure immediate announcement by assistive technologies.🎯 Why:
♿ Accessibility:
<label htmlFor="email-input">for the email field.aria-invalidandaria-describedbyfor error states.role="alert".📸 Verification:
PR created automatically by Jules for task 474735464200036666 started by @BenjaminWie