This repository was archived by the owner on Jun 4, 2021. It is now read-only.
Open
Conversation
When fetching records from CloudKit, a new recordID properyt was being created in the processing, which meant that the record IDs would be different instances, and the dictionary lookup could fail.
jsorge
force-pushed
the
ckrecord-inject-recordid
branch
from
43fffe1 to
88a09f3
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my scenario I was looking up a single record by its
CKRecordID. The record fetch came back nil because when it was constructed it had a newCKRecordIDmade in the initializer (giving me 2 different instances of the same record ID). The effect was that the hash was different and I would not get the record I wanted even though the fetch completed properly.The fix is to inject an optional record ID and use it instead of constructing a new one.
I based this on the Xcode 10 branch I submitted #20 to address as well. I'd merge that one before this one to keep the changeset minimal.