Refactor microcontroller wrappers, refactor nRF52 devices#502
Draft
ducky64 wants to merge 29 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the microcontroller wrapper:
Note, ideally both the from and to remapping would be put in the wrapping class, however the to remapping requires the model block to be solved, which the current generator structure does not support. A future structure that enables this might be separating param-only generators from structural (circuit) generators.
Updates the RP2040 to use this new style, adding a _model param to the device to remove requirement for some ports. Migrates the nRF52 devices to use microcontroller wrappers.
Adds a unit test based on the RP2040 that tests automatic assignment, specified assignment (checking remapping), and overflow.
Also refactors the base pin map util to:
TODOs for future PRs:
TODO changes