models: Prepend empty item to Alma Item Set lists #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we have two dropdowns with the same name, their values will both be sent on requests. The sandbox dropdown is last, so its value will take precedence over the production list. By having an empty item as the first item, the value will be blank and the selected item in the production list will be used. Closes: AP-560
anarchivist
approved these changes
Jan 23, 2026
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
r+, minor nit re: making the purpose of this change explicit.
| # We can only fetch 100 item sets at a time so we | ||
| # have to loop through the API to get all of them | ||
| sets = [] | ||
| sets = [['', '']] |
Member
There was a problem hiding this comment.
nit: should we move this line to just under the method and add a comment about why it's initializing an Array containing an Array with 2 empty strings as its elements?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have two dropdowns with the same name, their values will both be sent on requests. The sandbox dropdown is last, so its value will take precedence over the production list. By having an empty item as the first item, the value will be blank and the selected item in the production list will be used.
Closes: AP-560
I was obviously unable to test this (as I didn't want to set any notes on Alma item sets), but stubbing out the request logic locally seemed to do the right thing. We should probably have someone in Collections test this in staging before pushing to production.