Fix error if Color is indexed with a non-string#1
Open
Benjamin-Dobell wants to merge 1 commit into
Open
Conversation
00f6e2c to
ab165ef
Compare
Member
Author
|
Force pushed in some tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment non-string access on
Colore.g.will raise an error.
Whilst the above example could reasonably be considered user error, index keys (i.e. numbers) are funnelled through when indexing a
Colorinstance. So if you attempt to index aColorinstance outside the range [1, 4], rather than gettingnilback as you'd expect for non-existent keys on atable, instead an error is presently being raised.Reproduction
e.g. Entering the following in TTS' chat:
Leads to:
where as you'd expect to see
nillogged.