Metamethods for dividing a Vector and getting the reciprocal Vector#8
Open
Chr1Z93 wants to merge 2 commits into
Open
Metamethods for dividing a Vector and getting the reciprocal Vector#8Chr1Z93 wants to merge 2 commits into
Chr1Z93 wants to merge 2 commits into
Conversation
zerothi
reviewed
Aug 12, 2025
0x57e11a
requested changes
May 7, 2026
There was a problem hiding this comment.
reopening @zerothi's comment, it would be best to either
- permit
number / Vector(given that we're already applying componentwise operations, this would be well defined asVector(n / x, n / y, n / z)) - or hard-error deny
number / Vectoroperations
rather than silently failing with a nil
Author
Updated it so that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example: