Skip to content

feat(types): add inter-service HTTP client configuration types#194

Merged
therealjhay merged 2 commits into
Betta-Pay:mainfrom
HassanKorey:feat/shared-http-client-config
Jun 30, 2026
Merged

feat(types): add inter-service HTTP client configuration types#194
therealjhay merged 2 commits into
Betta-Pay:mainfrom
HassanKorey:feat/shared-http-client-config

Conversation

@HassanKorey

Copy link
Copy Markdown
Contributor

Description

Adds shared HTTP client configuration types (ServiceName and ServiceClientConfig) to shared/types/index.ts. This ensures type consistency when implementing inter-service HTTP calls across the BettaPay backend, such as from the API Gateway.

Acceptance Criteria Met:

  • Defined ServiceClientConfig type: { baseUrl: string; timeout: number; retries: number; authToken?: string }
  • Defined ServiceName as a union of the 4 requested service names
  • Exported both types from @bettapay/shared-types

Fixes / Closes: #106


Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring / Performance (clean-up or performance optimization without behavioral changes)
  • Documentation / CI (changes to docs, workflows, config files)

Verification & Test Plan

I verified these changes by confirming that the @bettapay/shared-types workspace type-checks and builds perfectly. Note: There is a pre-existing infrastructure issue on the main branch causing a type-check failure in services/settlement-engine due to a missing @prisma/client export; this is entirely unrelated to these type additions.

Automated Tests

# Verify all TS types (note: pre-existing Prisma issue on main may cause settlement-engine to fail here)
pnpm -r type-check

# Verify the specific shared library compiles perfectly
pnpm --filter '@bettapay/shared-types' build

@drips-wave

drips-wave Bot commented Jun 29, 2026

Copy link
Copy Markdown

@HassanKorey Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@therealjhay

Copy link
Copy Markdown
Contributor

kindly resolve conflict

@HassanKorey

Copy link
Copy Markdown
Contributor Author

@therealjhay conflict resolved

@therealjhay therealjhay merged commit ed41b41 into Betta-Pay:main Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add shared HTTP client configuration type

2 participants