feat(validation): add currency code enum for input validation#211
Merged
Conversation
CurrencyCode enum (USDC, EURT, NGN) replaces plain string validation in asset/currency fields, providing better error messages and type safety.
|
@zinodict121 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly resolve conflict |
Contributor
Author
I have resolved the conflict |
Contributor
There are still conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89
Summary
Replaces plain
z.string()validation on currency fields with a typedCurrencyCodeenum, improving runtime error messages and enabling IDE autocompletion.Changes
CurrencyCodeasz.enum(['USDC', 'EURT', 'NGN'])inshared/validation/currency.tsCurrencyCodeTypeScript type inshared/validation/index.tsCreatePaymentBody.assetto useCurrencyCodeCreateSettlementBody.assetto useCurrencyCodefrom/tofields to useCurrencyCodelatestLedgerCursor) inservices/indexer/src/index.tsto restore a green testing baseline.Why
Currency codes were previously validated as arbitrary strings, meaning invalid values like
"USD"or"usd"would pass schema validation silently. The enum provides:CurrencyCodetype)Testing
pnpm testpnpm -r type-checkExtensibility
To add a new currency, update the enum in
shared/validation/currency.ts:```ts
export const CurrencyCode = z.enum(['USDC', 'EURT', 'NGN', 'NEW_CURRENCY']);
```
No other changes are required.
Checklist