Add loading skeletons for all data-dependent pages#159
Merged
Conversation
|
@Majormaxx is attempting to deploy a commit to the therealjhay's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Majormaxx Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly resolve conflicts |
Created DashboardSkeleton, TableSkeleton, and CardGridSkeleton components that mirror page layouts with animate-pulse placeholders. Pages now show skeletons during data loading instead of blank areas. Added merchant layout loading.tsx for route-level loading states.
Majormaxx
force-pushed
the
40-loading-skeletons
branch
from
c63aaab to
3cd6e23
Compare
Contributor
Author
|
@therealjhay Rebased onto main and resolved all merge conflicts. Lint and build should be clean now (remaining dashboard lint errors are pre-existing in main). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created skeleton components that mirror the layout of each page's content area using Tailwind's
animate-pulsewith rounded blocks. Pages show skeletons during data loading instead of blank areas.New components:
components/skeletons/DashboardSkeleton.tsx— stat card grid + chart area + recent activitycomponents/skeletons/TableSkeleton.tsx— configurable ghost rows for tablescomponents/skeletons/CardGridSkeleton.tsx— card grid placeholders for payment links, FX pairs, etc.Modified pages:
DashboardSkeletonfor 500ms on mountTableSkeletoninside card during loadingloading.tsxfor merchant route groupUtility:
lib/hooks/useSimulatedLoading.ts— reusable hook for adding loading statesnpm run lint # cleanCloses #40