Add checkpoint capture: whole-session segmented memories#9
Conversation
0f57666 to
49dac04
Compare
- Add src/hook-spec.ts as the sole source of truth for the five lifecycle hooks (event, source file, binary, matcher) - Derive hook counts, the settings map, the summary listing, and the hook entries of BINARIES from HOOK_SPECS - Replace Record<string, unknown[]> hook maps with typed HookEntry - Drop stripLegacyBetterdbHooks: Stop is registered again, so both install paths already replace the legacy session-end entry on merge
A session whose Stop hook never checkpointed (fresh install before a restart, Valkey unreachable) arrives at session end whole. A single 8K selectTranscript cap silently discarded everything past it, reinstating the truncation checkpoint capture exists to remove. planTailSegments now chunks the tail exactly as Stop does and selects down only the final sub-threshold remainder. Also gate the event-file fallback on segment 0: after a checkpoint an empty tail means the transcript is already queued, so re-queueing the whole event file duplicated earlier segments.
A fully-checkpointed session leaves an empty tail, so session-end took the nothing-to-store path and returned before spawning the drainer. Stop enqueues segments but never drains, so everything it queued sat unsummarized until a later session happened to drain it.
49dac04 to
d0310ba
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d0310ba. Configure here.
| await writeCheckpoint(sessionId, { | ||
| byteOffset: result.endByte, | ||
| segment: checkpoint.segment + 1, | ||
| }); |
There was a problem hiding this comment.
Duplicate queue on checkpoint failure
Medium Severity
The Stop hook pushes a segment to Valkey before advancing the on-disk checkpoint. If writeCheckpoint fails after a successful pushIngestQueue, the checkpoint byte offset and segment counter stay unchanged, so the next Stop run re-enqueues the same transcript chunk under the same segment index.
Reviewed by Cursor Bugbot for commit d0310ba. Configure here.
There was a problem hiding this comment.
Acknowledged, but working as intended — not fixing.
The push-before-checkpoint ordering is deliberate. It yields at-least-once: if writeCheckpoint fails after a successful pushIngestQueue, the next Stop re-enqueues the same chunk, and the worst case is one duplicate near-identical memory. Reversing it to checkpoint-then-push would yield at-most-once: a failed push after an advanced checkpoint would lose that segment permanently, with nothing to detect it.
This plugin exists precisely to stop silently losing session content — the bug it was written to fix stored empty husks on the success path for eight days. Given that, duplicating beats dropping, so the current order is the safe one.
Scope of the window is also narrow: it requires the /tmp temp-file rename to fail after a successful RPUSH. The checkpoint write is already atomic (temp + rename), runHook exits 0 either way, and the drain's isEmptySummary guard independently drops anything that summarizes to nothing.
Noting for the record that this is the third independent review to raise it, which says the intent isn't legible enough in the code — that's a fair signal even though the behavior stands.
install matched existing entries on BIN_DIR or the literal "betterdb", so a registration written by register-hooks.ts from a checkout not named betterdb went unrecognized: it survived the merge and kept firing next to the new entry. Derive the match from HOOK_SPECS' source filenames, which hold wherever the checkout lives, and keep install paths as extra markers. Both install paths now share one definition of ours.
- Build the settings map with buildHookMap instead of a third hardcoded copy of the five lifecycle hooks - Print the summary via formatHookSummary, now parameterized so the shell path shows dist binary paths and the dev path source files - Verify each spec's binary is actually registered instead of counting keys, which reported success even with a hook missing
Writing `{ ...existing, hooks }` replaced the whole hooks block, so
installing deleted every hook this plugin did not write — including
third-party entries on events we never register.
Merge per event and drop only our own entries, matching the behaviour
of the other two install paths. Reinstalling stays idempotent.


Problem
After #8 moved capture to
SessionEnd, a latent cap surfaced:selectTranscriptkeeps only 8,000 chars, so a long session now captures ~5% of itself into a single memory. Distinct topics (PR review, debugging, a design discussion) collapse into one truncated summary, which also hurts recall — near-duplicate/bunched content always scores "low" at the confidence gate.Change
A new
Stophook checkpoints the transcript incrementally: every ~8,000 chars it queues one segment to the existing ingest queue and advances a/tmpcheckpoint file — doing zero model work.SessionEndflushes only the post-checkpoint tail and spawns the existing detached drain. A long session becomes many distinct, sequential segments instead of one husk. The drain is unchanged (Track 1's empty-summary guard still applies); session consolidation and provider-aware thresholds are deliberately deferred.Implementation (7 TDD tasks)
nextChunk— pure decision (in turns, resuming in bytes), table-tested with no fs/Valkey/model.parseTranscriptLine+ byte-offsetparseTurnsFrom(replaces the private parser insession-end, de-duplicated).Stophook — stat-gate → parse new bytes →nextChunk→ queue + advance toendByte(never EOF).session-endflushes only the tail from the checkpoint offset, tagssegment, cleans up.index.ts,register-hooks.ts,install-hooks.sh.[0,1,2,…]+ a tail against real Valkey.Install-path refactor
Registering a fifth hook surfaced drift the branch inherited: each install path kept its own copy of the hook map, next to a literal
Registered 5 hookscount and a hand-aligned summary listing — so adding a hook meant remembering four places.src/hook-spec.tsis now the single typed source of truth (HookEvent/HookSpec/HookEntry/HookCommand— no moreRecord<string, unknown[]>and no casts).index.tsandregister-hooks.tsderive their settings map, hook count, summary listing, and — inindex.ts— the hook entries ofBINARIESfromHOOK_SPECS.isOwnHookEntryreplaces substring matching on"betterdb"/BIN_DIRwhen identifying our own entries to replace.The
hook-migrationstrip is deleted (module + 89-line test file). It only ever coveredStop, andStopis registered again, so both install paths' merges already replace the legacysession-endentry before the strip could. Verified rather than assumed: replaying a v0.4.xsettings.json(legacysession-endonStop, a third-partyStophook, an unrelatedPreCompacthook) through both paths with and without the strip produces byte-identical output — stale entry gone, third-party hooks and unrelated keys preserved.Review & verification
Each task passed an independent spec+quality review (three needed a fix loop: a plan off-by-one, a missing byte-offset test, a dead tail-flush path — all fixed). A whole-branch review verified all four load-bearing invariants end-to-end — no model work on hooks, checkpoint advances to
endBytenot EOF, segment continuity acrossStopfirings +SessionEnd, tail parses from the offset — verdict ready to merge.bun run typecheckclean ·bun test tests/unit164/164 ·bun test tests/integration0 fail (checkpoint test runs unskipped).Note
Medium Risk
Changes the memory capture path and mutates ~/.claude/settings.json hook merges, but behavior is heavily unit/integration tested and hook replacement is intentionally conservative to avoid deleting third-party hooks.
Overview
Long sessions no longer collapse into a single 8K-char memory. A new
Stophook (stop-checkpoint) incrementally queues ~8K transcript segments to Valkey (no LLM work) and advances a per-session/tmpcheckpoint (byteOffset+segment).SessionEndresumes from that offset, usesplanTailSegmentsto chunk any remainder like Stop would (instead of oneselectTranscriptcap), tags each queue item withsegment, spawns the drain when Stop already queued work, and removes the checkpoint on cleanup.Shared
src/memory/checkpoint.tsaddsnextChunk, byte-offsetparseTurnsFrom, and checkpoint I/O; transcript parsing moves toparseTranscriptLineintranscript.ts.Hook registration is centralized in
hook-spec.ts(HOOK_SPECS,buildHookMap,isOwnHookEntry,formatHookSummary) and wired throughindex.ts,register-hooks.ts, andinstall-hooks.sh.hook-migration.tsand its tests are removed; legacyStopentries are replaced viaisOwnHookEntry(source filenames + install markers) while preserving third-party hooks.Reviewed by Cursor Bugbot for commit d045272. Bugbot is set up for automated code reviews on this repo. Configure here.