forked from ynab/heroku-tailscale-buildpack
-
Notifications
You must be signed in to change notification settings - Fork 1
Refactor for latest version of Tailscale #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CoderMiguel
wants to merge
12
commits into
BetterNowOrg:upgrade-tailscale
Choose a base branch
from
CoderMiguel:latest
base: upgrade-tailscale
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2fbfeb5
Use latest tailscale version
prognostikos 24023e8
whitespace/style
prognostikos 53dcb53
Use integer math for wait calculations
prognostikos e674250
Add ability to set TAILSCALE_RUNNING_TIMEOUT
prognostikos bec36b6
refactor to tailscale up command
CoderMiguel c562520
Merge pull request #2 from CoderMiguel/timeout
CoderMiguel 35a6989
dynamically pick the latest version as the default, but still allow c…
CoderMiguel e9da0fb
clean up
CoderMiguel 46a327f
add version number to logging
CoderMiguel 34bd078
correct typo
CoderMiguel bc871c7
rollback arch logic
CoderMiguel 0346ed2
added TODO for new version log if not using the latest version
CoderMiguel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,20 +8,25 @@ if [ -z "$TAILSCALE_AUTH_KEY" ]; then | |
| fi | ||
|
|
||
| wait_for_tailscale_running() { | ||
| timeout=5 # Timeout in seconds | ||
| interval=0.5 # Interval between checks | ||
| elapsed=0 | ||
|
|
||
| while [ "$elapsed" -lt "$timeout" ]; do | ||
| state=$(tailscale status -json | jq -r .BackendState) | ||
| if [ "$state" = "Running" ]; then | ||
| return 0 | ||
| fi | ||
| sleep "$interval" | ||
| elapsed=$(echo "$elapsed + $interval" | bc) | ||
| done | ||
|
|
||
| return 1 | ||
| timeout=${TAILSCALE_RUNNING_TIMEOUT:-5} # Timeout in seconds | ||
| interval=0.5 # Interval between checks | ||
|
|
||
| # convert to milliseconds so we can use integer math | ||
| timeout_ms=$(awk "BEGIN {print $timeout * 1000}") | ||
| interval_ms=$(awk "BEGIN {print $interval * 1000}") | ||
|
|
||
| elapsed=0 | ||
|
|
||
| while [ "$elapsed" -lt "$timeout_ms" ]; do | ||
| state=$(tailscale status -json | jq -r .BackendState) | ||
| if [ "$state" = "Running" ]; then | ||
| return 0 | ||
| fi | ||
| sleep "$interval" | ||
| elapsed=$((elapsed + interval_ms)) | ||
| done | ||
|
|
||
| return 1 | ||
| } | ||
|
|
||
| if [ -z "$TAILSCALE_HOSTNAME" ]; then | ||
|
|
@@ -39,14 +44,12 @@ else | |
| TAILSCALE_HOSTNAME="$TAILSCALE_HOSTNAME" | ||
| fi | ||
| tailscaled -cleanup > /dev/null 2>&1 | ||
| (tailscaled -verbose ${TAILSCALED_VERBOSE:--1} --tun=userspace-networking --socks5-server=localhost:1055 > /dev/null 2>&1 &) | ||
| (tailscaled -verbose ${TAILSCALED_VERBOSE:--1} --tun=userspace-networking --socks5-server=localhost:1055 > /dev/null 2>&1 &) | ||
| tailscale up \ | ||
| --authkey="${TAILSCALE_AUTH_KEY}?preauthorized=true&ephemeral=true" \ | ||
| --authkey="${TAILSCALE_AUTH_KEY}" \ | ||
| --hostname="$TAILSCALE_HOSTNAME" \ | ||
| --advertise-tags=${TAILSCALE_ADVERTISE_TAGS:-} \ | ||
| --accept-routes \ | ||
| --timeout=15s \ | ||
| ${TAILSCALE_ADDITIONAL_ARGS:---timeout=15s} | ||
| ${TAILSCALE_ADDITIONAL_ARGS:---accept-routes --timeout=15s} | ||
|
Comment on lines
-48
to
+52
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change is covered in my other PR |
||
|
|
||
| export ALL_PROXY=socks5://localhost:1055/ | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is covered in my other PR