Open
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/juggernaut9/pokemon-hacktoberfest/50hlmdute |
SheW0lf
commented
Oct 4, 2020
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| yarn.lock |
Author
There was a problem hiding this comment.
I use yarn so added it to the .gitignore file
| "@testing-library/jest-dom": "^4.2.4", | ||
| "@testing-library/react": "^9.5.0", | ||
| "@testing-library/user-event": "^7.2.1", | ||
| "axios": "^0.20.0", |
Author
There was a problem hiding this comment.
added axios however fetch could have done the same job
Owner
|
Hey, this is a big update, I'll check it tomorrow and merge it to a separate branch (not master) |
Author
|
Yeah no worries, just having fun with the repo! 🦇🎃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This did not have an issue on the board
Purpose
To incorporate the Poke API into the existing application
Context
I noticed the app was relying on manual input to generate the Pokemon, so I decided to hook up the Poke API in order to dynamically generate each of the original 151 Pokemon. Complete with image, name and types, and the added bonus of easily incorporating other features in the future.