You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request improves the talkinghead-lipsync-plugin for Vite to ensure lipsync .mjs files are correctly resolved and emitted during the build, addressing issues with missing assets in production environments. The main changes include making the plugin more robust in locating the lipsync modules and explicitly emitting the necessary .mjs files.
Low Risk
Scoped to the web Vite build plugin and static asset emission; no auth, API, or data-path changes.
Overview
Fixes production lipsync failures where TalkingHead’s dynamic ./lipsync-*.mjs requests were resolved at build time but never shipped, so hosts like Vercel served index.html for paths such as /assets/lipsync-fr.mjs.
The Vite plugin now locates@met4citizen/talkinghead’s modules folder via require.resolve (with a node_modules fallback) using ESM-safe paths instead of __dirname, and adds a generateBundle hook that copies every lipsync-*.mjs file into assets/ as static build output alongside the existing resolveId mapping.
Reviewed by Cursor Bugbot for commit cb2e632. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This pull request improves the
talkinghead-lipsync-pluginfor Vite to ensure lipsync.mjsfiles are correctly resolved and emitted during the build, addressing issues with missing assets in production environments. The main changes include making the plugin more robust in locating the lipsync modules and explicitly emitting the necessary.mjsfiles.Linked GitHub Ticket
Closes EpitechPromo2027/G-EIP-600-NAN-6-1-eip-tugdual.de-reviers#203
Workspace