fix: hide roadmap card behind its open popover (#204) - #176
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🚅 Deployed to the TalkUp.AI-pr-176 environment in talk-up-ai
|
badarouzia
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening a roadmap topic card's "Read more" popover left the collapsed card painting underneath it — its bottom border and "Read more" link showed through below the popover.
The popover is absolutely positioned over the card but is wider than it (
20remvs the ~12rem timeline column). The same rationale text therefore wraps into fewer lines, so the popover renders shorter than the card it is meant to cover, and the bottom strip of the card stays visible.Measured at 1920x1080 on
main(Step 3 card):→ 18px of the collapsed card visible below the popover; it also intercepted pointer events aimed at the popover.
Fix
While the popover is open, the card is:
invisible— hidden but kept in flow, so the timeline row does not reflow (card height stays 206)aria-hidden+inert— not announced, not focusable, no pointer interceptionFocus moves to the panel on open and returns to the card on close, since
inertwould otherwise drop focus to<body>.The popover also gets
min-w-fullso it can never be narrower than the card behind it.Verification
Driven in a real browser at 1920x1080 against a roadmap fixture reproducing the reported geometry:
visiblehiddenUnit test added — verified red without the fix, green with it.
tsc -b, oxlint and prettier all clean.