feat: gate agenda external app connectors behind VITE_SHOW_AGENDA_CONNECTORS#179
Open
BhuvanArn wants to merge 1 commit into
Open
feat: gate agenda external app connectors behind VITE_SHOW_AGENDA_CONNECTORS#179BhuvanArn wants to merge 1 commit into
BhuvanArn wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🚅 Deployed to the TalkUp.AI-pr-179 environment in talk-up-ai
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Hides the Agenda page's Google/Apple connectors for the demo by gating them behind a
VITE_SHOW_AGENDA_CONNECTORSenv flag (default off). The connector code is kept, not deleted — setVITE_SHOW_AGENDA_CONNECTORS=trueinweb/.envto render it again.Why.
ExternalAppConnector(web/src/routes/agenda.tsx) offers Connect Google / Connect Apple, but no OAuth flow exists behind either button. Clicking runs asetTimeout(…, 500)and flips local React state to a "Connected" state that grants no calendar access, fetches no events, and does not survive a reload:It reads as a working integration while doing nothing — not something to demo.
How. Follows the existing
VITE_SHOW_WS_DEBUGprecedent (64ac7bf):import.meta.env.VITE_SHOW_AGENDA_CONNECTORS === 'true'.web/src/vite-env.d.ts, documented commented-out inweb/.env.example.web/src/routes/-agenda.spec.tsxlocks both states (hidden by default, rendered when the flag is on) so the gate cannot silently rot into a deletion.Verification. Driven in a real browser against the local stack, not just tests:
=trueZero console errors (the single warning is a pre-existing dependency-level JSX-transform notice, unrelated to this change). Gate: 1264 tests / 129 files pass, lint 0 warnings 0 errors, format clean,
tsc -bclean.Out of scope. The sidebar's "Link Integrations" row (
web/src/components/organisms/sidebar/index.tsx) renders Google/LinkedIn icons with noonClickat all — decorative rather than fake-connected. Noted in #209 as its own ticket.Linked GitHub Ticket
Relates to EpitechPromo2027/G-EIP-600-NAN-6-1-eip-tugdual.de-reviers#209
Workspace
Screenshots
Verified in a real browser against the local stack (real backend on :8080), with the DOM asserted before each capture. Screenshots shared with the team directly rather than hosted from a scratch branch.
Default (flag unset) — connectors hidden: the "Connections" card is gone; calendar, mini-calendar and next-event card all render with no layout gap (Agenda sidebar drops from 3 children to 2).
With
VITE_SHOW_AGENDA_CONNECTORS=true— connectors render again: the CONNECTIONS card returns with Connect Google and Connect Apple (sidebar back to 3 children).Reproduce locally:
VITE_SHOW_AGENDA_CONNECTORS=true npm run dev:weband open/agenda, then unset the flag and reload.