Skip to content

fix(biobridge): avoid token info loading when decimals known #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gaubee merged 3 commits into from
Jan 29, 2026
Merged

fix(biobridge): avoid token info loading when decimals known #359

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77c648d
fix(biobridge): keep tron contract hex for token info
Gaubee Jan 29, 2026
31c4473
fix(biobridge): avoid decimals loading when already known
Gaubee Jan 29, 2026
e02fe13
Merge remote-tracking branch 'origin/main' into feat/issue-355
Gaubee Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions miniapps/biobridge/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,10 +249,12 @@ export default function App() {
: undefined;
const tokenInfoTargets = useMemo(
() =>
forgeOptions.map((option) => ({
chain: option.externalChain,
address: option.externalInfo.contract,
})),
forgeOptions
.filter((option) => option.externalInfo.decimals === undefined)
.map((option) => ({
chain: option.externalChain,
address: option.externalInfo.contract,
})),
[forgeOptions],
);
const { tokenInfoMap, loadingMap } = useTokenInfoMap(tokenInfoTargets);
Expand All @@ -262,7 +264,8 @@ export default function App() {
? getTokenInfoKey(selectedOption.externalChain, externalTokenAddress)
: undefined;
const tokenInfo = tokenInfoKey ? tokenInfoMap[tokenInfoKey] : undefined;
const tokenInfoLoading = tokenInfoKey ? Boolean(loadingMap[tokenInfoKey]) : false;
const needsTokenInfo = Boolean(externalTokenAddress && externalDecimals === undefined);
const tokenInfoLoading = needsTokenInfo && tokenInfoKey ? Boolean(loadingMap[tokenInfoKey]) : false;
const resolvedExternalDecimals = tokenInfo?.decimals ?? externalDecimals;
const usingRemoteDecimals = Boolean(externalTokenAddress) && tokenInfo?.decimals !== undefined;
const resolvedExternalSymbol = tokenInfo?.symbol ?? selectedOption?.externalAsset ?? '';
Expand All @@ -271,7 +274,7 @@ export default function App() {
const handleConfirm = useCallback(async () => {
if (!externalAccount || !internalAccount || !selectedOption) return;
const tokenAddress = selectedOption.externalInfo.contract?.trim();
if (tokenAddress && tokenInfoLoading) {
if (needsTokenInfo && tokenInfoLoading) {
setError(t('error.decimalsLoading'));
return;
}
Expand Down Expand Up @@ -310,7 +313,7 @@ export default function App() {
internalAsset: selectedOption.internalAsset,
internalAccount,
});
}, [externalAccount, internalAccount, selectedOption, amount, forgeHook, resolvedExternalDecimals, t]);
}, [externalAccount, internalAccount, selectedOption, amount, forgeHook, resolvedExternalDecimals, needsTokenInfo, t]);

const handleReset = useCallback(() => {
setRechargeStep('swap');
Expand Down