feat(core.buildCommand): buildCommand DAG option#339
Merged
Conversation
wrapperFunction and builderFunction were too similar. It was the right decision to split up the resposibility of wrapping from the rest of the logic, so they can be overridden separately, but it could have been done much better. What we want wrapperFunction to do, is be able to see config, and provide a buildCommand string. They can already see the config. Why not just let people give us strings, for builderFunction to run? Added a buildCommand dag option. Used it for wlib.modules.makeWrapper and wlib.modules.symlinkScript This also gives a clear path for how to add helper modules which need to run build commands without immediately using up all the available stdenv hooks wrapperFunction option still exists, however it is now declared by the makeWrapper module, and can only return a build command string builderFunction is now in charge of running its `buildCommand` argument, which will always contain a build command string, as opposed to processing a wrapper argument which usually but not always contains a build command string. If you wish to pass other values to builderFunction, you may declare it in an option, builderFunction can see all of config still.
42f6208 to
1e225f6
Compare
BirdeeHub
added a commit
that referenced
this pull request
Mar 15, 2026
#339 updated some things. Did not update these descriptions.
BirdeeHub
added a commit
that referenced
this pull request
Mar 15, 2026
#339 updated some things. Did not update these descriptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrapperFunction and builderFunction were too similar.
It was the right decision to split up the resposibility of wrapping from
the rest of the logic, so they can be overridden separately, but it
could have been done much better.
What we want wrapperFunction to do, is be able to see config, and
provide a buildCommand string. They can already see the config. Why not
just let people give us strings, for builderFunction to run?
Added a buildCommand dag option.
Used it for wlib.modules.makeWrapper and wlib.modules.symlinkScript
This also gives a clear path for how to add helper modules which need to
run build commands without immediately using up all the available stdenv
hooks
wrapperFunction option still exists, however it is now declared by the
makeWrapper module, and can only return a build command string
builderFunction is now in charge of running its
buildCommandargument,which will always contain a build command string, as opposed to
processing a wrapper argument which usually but not always contains a
build command string. If you wish to pass other values to
builderFunction, you may declare it in an option, builderFunction can
see all of config still.
Also,
Added a
constructFileshelper module, which is included in the default module.