feat(FIAT-311): config-driven fiat coins and index 12 new currencies#8559
Merged
Conversation
drew-bitgo
force-pushed
the
drew/fiat-311-index-new-currencies
branch
3 times, most recently
from
7dac34e to
4eff7de
Compare
…ig-driven Fiat class Replace 36 individual fiat coin class files with a single generic Fiat class that takes a config object (chain, fullName, baseFactor). All currencies are defined in a config array and registration is automatic via a loop in coinFactory. Testnet variants are derived automatically from mainnet configs. This reduces the effort to add a new fiat currency from ~6 files and 150+ lines of boilerplate to a single config line. FIAT-311 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add CAD, AUD, HKD, CHF, SEK, NOK, JPY, CNY, NZD, IDR, KRW, ZAR to:
- fiatCoins config array in sdk-core (12 entries)
- UnderlyingAsset enum (12 entries)
- allCoinsAndTokens fiat() entries (24: 12 mainnet + 12 testnet)
- ofcCoins ofc/tofc entries (12 mainnet + 12 testnet)
JPY and KRW use decimalPlaces=0; all others use 2.
3 testnet OFC entries use ofct:{code} naming (ofct:cad, ofct:aud, ofct:hkd)
to avoid collisions with existing ERC20 tokens (TrueCAD, TrueAUD, TrueHKD).
FIAT-311
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
drew-bitgo
force-pushed
the
drew/fiat-311-index-new-currencies
branch
from
4eff7de to
a10c635
Compare
zahin-mohammad
approved these changes
Apr 20, 2026
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
lgtm. Is there plans to move FIAT into its own sdk-module like all other coins?
Contributor
Author
|
Thats the plan. I wanted to condense things first |
Schultzer
approved these changes
Apr 20, 2026
Contributor
Schultzer
left a comment
Schultzer
left a comment
There was a problem hiding this comment.
This looks good to me, nice with the simplicity.
feng-bitgo
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fiatclass. Replaces 36 boilerplate files (~700 LOC) with one config array (~130 LOC). Adding a new fiat currency now requires a single config line instead of ~6 files.UnderlyingAsset,allCoinsAndTokens, andofcCoins.decimalPlaces=0/baseFactor=1; all others usedecimalPlaces=2/baseFactor=100.ofct:{code}naming (ofct:cad,ofct:aud,ofct:hkd) to avoid collisions with existing ERC20 tokens (TrueCAD, TrueAUD, TrueHKD).Modules touched
@bitgo/sdk-coreFiatclass +fiatCoinsconfig array; deleted 36 individual class filesbitgocoinFactory.tsuses dynamic loop;coins/index.tsre-exports genericFiat@bitgo/staticsUnderlyingAssetentries, 24fiat()entries, 24ofc()/tofc()entriesTest plan
tsc --noEmitpasses forsdk-core,bitgo, andstaticswallet-platform(already config-driven, should pick up new currencies via statics bump)fiat-transfer-typesandprime-microserviceschanges in separate PRsFIAT-311
🤖 Generated with Claude Code