Conversation
Changed buildTransaction() and buildFromVersionedData() to return Transaction and VersionedTransaction objects instead of raw bytes. This allows callers to inspect the transaction before serializing, which is more ergonomic and matches the existing Transaction API. Callers that need bytes can simply call .toBytes() on the result.
OttoAllmendinger
requested changes
Jan 30, 2026
| const txBytes = buildTransaction(intent); | ||
| const tx = buildTransaction(intent); | ||
| const txBytes = tx.toBytes(); | ||
| const parsed = parseTransaction(txBytes); |
Contributor
There was a problem hiding this comment.
why not parse the tx directly instead of going through the byte representation here?
you can widen parseTransaction so that accepts both Transaction or bytes for convenience
parseTransaction now accepts Uint8Array, Transaction, or VersionedTransaction directly, avoiding the need for callers to explicitly call .toBytes() when parsing a transaction that was just built. Ticket: BTC-2988
OttoAllmendinger
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildTransaction()to returnTransactioninstead ofUint8ArraybuildFromVersionedData()to returnVersionedTransactioninstead ofUint8ArrayfromWasm()factory methods to Transaction and VersionedTransaction classes.toBytes()on the resultThis addresses feedback from PR #113 to return rich Transaction objects that can be inspected before serializing, which is more ergonomic.
Test plan