fix(wasm-solana): include pkg/ in artifact upload to preserve dist/ path#130
Closed
lcovar wants to merge 1 commit into
Closed
fix(wasm-solana): include pkg/ in artifact upload to preserve dist/ path#130lcovar wants to merge 1 commit into
lcovar wants to merge 1 commit into
Conversation
lcovar
force-pushed
the
fix/wasm-solana-publish
branch
from
e2831d5 to
93bed96
Compare
The upload-artifact action uses the least common ancestor of all paths as the artifact root. With only dist/ specified, the artifact structure loses the dist/ prefix, causing files to be extracted to the wrong location during publish. Adding pkg/ (matching wasm-utxo's pattern) ensures the common ancestor is packages/wasm-solana/, preserving the dist/ directory structure.
lcovar
force-pushed
the
fix/wasm-solana-publish
branch
from
93bed96 to
acdd056
Compare
davidkaplanbitgo
approved these changes
Feb 4, 2026
davidkaplanbitgo
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upload-artifact action uses the least common ancestor of all paths as the artifact root. With only dist/ specified, the artifact structure loses the dist/ prefix, causing files to be extracted to the wrong location during publish.
Adding pkg/ (matching wasm-utxo's pattern) ensures the common ancestor is packages/wasm-solana/, preserving the dist/ directory structure.