Skip to content

ci: add manual @bitgo-beta SDK bump workflow#202

Open
pranavjain97 wants to merge 1 commit into
masterfrom
pranavjain/bump-sdk-workflow
Open

ci: add manual @bitgo-beta SDK bump workflow#202
pranavjain97 wants to merge 1 commit into
masterfrom
pranavjain/bump-sdk-workflow

Conversation

@pranavjain97
Copy link
Copy Markdown
Contributor

No description provided.

@pranavjain97 pranavjain97 requested a review from a team as a code owner May 14, 2026 20:33
@pranavjain97 pranavjain97 force-pushed the pranavjain/bump-sdk-workflow branch from 83cee97 to a0bec85 Compare May 14, 2026 20:38
Comment on lines +20 to +24
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '22.1.0'
cache: 'npm'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '22.1.0'
cache: 'npm'
- name: Get Node.js version from package.json
id: node-version
run: echo "NODE_VERSION=$(jq -r .engines.node package.json)" >> $GITHUB_OUTPUT
- name: Setup Node.js from engines
uses: actions/setup-node@v4
with:
node-version: ${{ steps.node-version.outputs.NODE_VERSION }}
cache: 'npm'

so we do not have to hardcode in CI

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat approach! 😮

just a question though: looks like we have engines defined as >= 22.x, so it would mean, the node version retrieved could be 22.x / 23.x/ 24.x; might be hard to reproduce, what do you guys think?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a valid concern. We should be pinning node versions I guess?

@gokulhost gokulhost requested review from a team and pranishnepal and removed request for ashleyzhao-design May 14, 2026 23:16
- name: Bump @bitgo-beta versions
run: npm run bump-versions

- name: Regenerate lockfile
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor optimization but if we add a step like the following:

- name: Early exit if nothing changed
  run: |
    if git diff --quiet HEAD -- package.json; then
      echo "No version bumps found, exiting."
      exit 0  # or use $GITHUB_OUTPUT to skip remaining steps
    fi

we can early return after the Bump version step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants