Conversation
Assignment3/Assignment3.py
Outdated
| sql1 = "select * from baseball.batter_counts" | ||
| database = "baseball" | ||
| user = "bita" | ||
| password = "salam" |
There was a problem hiding this comment.
Bita don't add your your password onto a file on github, you want to use an environment variable or something so people dont know it.
There was a problem hiding this comment.
If you added the pre-commit hook, it would have caught that and not let it get committed!
| ) | ||
|
|
||
| sql1 = "select * from baseball.batter_counts" | ||
| database = "baseball" |
There was a problem hiding this comment.
Don't put your password in plain text on the internet, you're going to want to use an environment variable.
Assignment3/Assignment3.py
Outdated
| numTrees=100, | ||
| predictionCol="pred_survived", | ||
| ) | ||
| random_forest_fitted = random_forest.fit(results) |
There was a problem hiding this comment.
I dont know if your transformer is working right
There was a problem hiding this comment.
Ok I changed if from random forest regressor to linear regression. for me it runs without error, can you run it too?
TDerig23
left a comment
TDerig23
left a comment
There was a problem hiding this comment.
I left an extra comment about your transformer
3 participants
No description provided.