Minimum viable PoW change#5
Open
luke-jr wants to merge 11 commits intoBitcoinHardfork:0.14-uasf_backup_hardforkfrom
Open
Minimum viable PoW change#5luke-jr wants to merge 11 commits intoBitcoinHardfork:0.14-uasf_backup_hardforkfrom
luke-jr wants to merge 11 commits intoBitcoinHardfork:0.14-uasf_backup_hardforkfrom
Conversation
…h the same return
luke-jr
force-pushed
the
0.14-bak_hf-minimum
branch
6 times, most recently
from
58446fe to
b06dbdc
Compare
luke-jr
force-pushed
the
0.14-bak_hf-minimum
branch
from
b06dbdc to
3aae881
Compare
luke-jr
force-pushed
the
0.14-bak_hf-minimum
branch
from
3aae881 to
65d8845
Compare
rodasmith
reviewed
Aug 27, 2017
| int64_t nTryTime; | ||
| ++nMinTime; | ||
| while (nMinTime < nMaxTime) { | ||
| nTryTime = nMinTime + ((nMaxTime - nMinTime) / 2); |
There was a problem hiding this comment.
(nit) May be more readable as nTryTime = (nMinTime + nMaxTime) / 2;
| return pindexLast->nBits; | ||
| } else { | ||
| // Go back by what we want to be 14 days worth of blocks | ||
| int nHeightFirst = pindexLast->nHeight - (params.DifficultyAdjustmentInterval()-1); |
There was a problem hiding this comment.
(nit) Would this be more readable as pindexLast->nHeight + 1 - params.DifficultyAdjustmentInterval() or is it intentionally considering just 2015 of the 2016 blocks?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messed up PR #1