test: normalize previous release binary names#349
Open
CDEN190 wants to merge 1 commit into
Open
Conversation
|
Maintainer review-assist for the Current visible state:
Review focus:
Suggested next step: run the focused Python helper tests and one previous-release functional-test setup path, then classify this as a small #32 test/devtools unblock if the non-overwrite behavior matches maintainer expectations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Normalize previous-release binaries extracted or built by
test/get_previous_releases.pyfrom upstream Bitcoin names to the Bitgesell names used by the functional test framework.Without this,
--previous-releasescan populatebin/bitcoindandbin/bitcoin-cli, while the test framework looks forbin/BGLdandbin/BGL-clifor versioned nodes.This adds a small helper plus unit coverage for the rename behavior.
Validation
python test\util\get_previous_releases_test.pypython -m py_compile test\get_previous_releases.py test\util\get_previous_releases_test.pypython test\lint\lint-tests.pygit diff --checkRefs #32