Skip to content

fix: validate transaction output index #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tolga-tom-nook wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate transaction output index #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/bitcoin/transaction_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,14 @@ func (tb *TransactionBuilder) getScript(
)
}

if uint64(utxo.Outpoint.OutputIndex) >= uint64(len(transaction.Outputs)) {
return nil, fmt.Errorf(
"transaction with hash [%s] does not have output index [%v]",
hash.Hex(InternalByteOrder),
utxo.Outpoint.OutputIndex,
)
}

return transaction.Outputs[utxo.Outpoint.OutputIndex].PublicKeyScript, nil
}

Expand Down
28 changes: 28 additions & 0 deletions pkg/bitcoin/transaction_builder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,34 @@ func TestTransactionBuilder_AddScriptHashInput(t *testing.T) {
}
}

func TestTransactionBuilder_AddPublicKeyHashInput_OutOfRangeOutputIndex(t *testing.T) {
localChain := newLocalChain()
builder := NewTransactionBuilder(localChain)

inputTransaction := &Transaction{
Version: 1,
Outputs: []*TransactionOutput{},
}

err := localChain.addTransaction(inputTransaction)
if err != nil {
t.Fatal(err)
}

inputTransactionUtxo := &UnspentTransactionOutput{
Outpoint: &TransactionOutpoint{
TransactionHash: inputTransaction.Hash(),
OutputIndex: 0,
},
Value: 1,
}

err = builder.AddPublicKeyHashInput(inputTransactionUtxo)
if err == nil {
t.Fatal("expected error for out-of-range output index")
}
}

func TestTransactionBuilder_AddOutput(t *testing.T) {
builder := NewTransactionBuilder(nil) // chain is not relevant here

Expand Down