copy repo from KickButtowski80/rails-vue-vuetify#9
Conversation
skamansam
left a comment
skamansam
left a comment
There was a problem hiding this comment.
There are a few notes about what not to merge. We should fix these. Most importantly, we should not be using CSS style includes - they are not tree-shaken, so we will be including too much dead code.
| @@ -1,12 +1,5 @@ | |||
| # README | |||
|
|
|||
There was a problem hiding this comment.
This file should be reverted. Use the current file instead of the new file.
| <%= csp_meta_tag %> | ||
|
|
||
| <%= stylesheet_link_tag 'application', media: 'all', 'data-turbolinks-track': 'reload' %> | ||
| <link href = "https://cdn.jsdelivr.net/npm/vuetify/dist/vuetify.min.css" rel = "stylesheet"> |
There was a problem hiding this comment.
This is no where near ideal. It defeats the purpose of having webpack/babel/etc. We should use tree-shaking package for this, instead of including the raw css here. PostCSS is setup below, so we should be using that, along with CSS Modules, for tree-shaking,
There was a problem hiding this comment.
I imported the following to hello_vue.js and now no need for the cdn
import 'vuetify/dist/vuetify.min.css'
| Bundler.require(*Rails.groups) | ||
|
|
||
| module QuestLists | ||
| module Rvv |
There was a problem hiding this comment.
This should be reverted
| adapter: redis | ||
| url: <%= ENV.fetch("REDIS_URL") { "redis://localhost:6379/1" } %> | ||
| channel_prefix: quest_lists_production | ||
| channel_prefix: rvv_production |
There was a problem hiding this comment.
This should be reverted
| # Use a real queuing backend for Active Job (and separate queues per environment). | ||
| # config.active_job.queue_adapter = :resque | ||
| # config.active_job.queue_name_prefix = "quest_lists_production" | ||
| # config.active_job.queue_name_prefix = "rvv_production" |
There was a problem hiding this comment.
this should be reverted
| @@ -1,11 +1,19 @@ | |||
| { | |||
| "name": "quest_lists", | |||
| "name": "rvv", | |||
There was a problem hiding this comment.
this should be reverted
| @@ -0,0 +1,12 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
We should be using postcss to tree-shake css, instead of including all the styles. If we don't use CSS Modules, or any of the benefits of PostCSS, we should definitely remove it.
| @@ -1 +1 @@ | |||
| 7KId8t/XynBn0te9eplC/CH+KabjZNO+nqtd0qehkkjFn6FWTTONUNmGiasZUqtMkSgUfoOVQJmoMfslG0pomifcQ/nN5Ry8Uzf7yA5W60JjU9RH05NN8N3QCD7j0W9WiLQs8Q5B419MylxnnqPc8vHzf/za63xG9r1PFdykyC5dM6qnRLHlGnIKum3P7b7pX759O2EdKyGFcOGl9DJGk1ueazzlKzx+mfZymgAss46WcCuOHIkP7jCPmIoPHAedqazPrnW9MIma2zmiIx2WhNPUw7NBSxFGfudhQMrkoVUPo+9CbaX6TxYLnark3Rpl9rsOcf7lAm1VHkP6eczWKl33KYsEHYmcZSVn6Cw0dy89zbQrMWTdU8VVU0t0qKMrhLcbjKuFkjdli01o+p+MKEEiZpdktAmB/vql--LwAQaesZM4ro5aUs--V8fqwqv5kNr9cBWaWDOc7g== No newline at end of file | |||
| PbdogYSdTI5ChMlQXWTLgCoD/EXdHIMZyRMNZ/a6xqjw15BqeNqhPdkURMA6XNssdBzzydL6muSjJHSqGPtT8kSftsFlr30CHpavqyyNowhWSzwf2AliGXTH3HEo/v5y0iq9izrWzobpXpcyHBXgLFOgLheXgelWSh+poFoNUZXTOT/gI4QgQnDkVUtTo4CZLQHhHnyWYnkoDKcL9J7c7MwMfmQxgtVuFxMD5SkhZMKceo8e8EDQ5BlT1AcgWagEvtKXfdmgydVOi6uW7szEvrNqx9Hyxx8P2gGjhH8mzf2KfcUNhgr2chjCdn/AwycpbibSsDD2mt7h9IwA7Wl3KKgbXemuIRbwt8r1XgPmT0FQH+odtEgBtAeujg0nxBaAMvWoe5iH89P7v+oRx0w2rtgNubqw1+tN4cOS--j33P9WMrXous267A--OljFhHTIfNS8x8pbIzMuFg== No newline at end of file | |||
There was a problem hiding this comment.
This should never ever be updated, FYI, but since we are starting from scratch, and don't have a DB initialized, it's ok. If it ever is updated, credentials won't work, and a new DB will have to be created.
2 participants
No description provided.