Skip to content

refactor: align test_agent_rbac with testing guide#1487

Open
sujaan-iqbal wants to merge 2 commits into
BlazeUp-AI:mainfrom
sujaan-iqbal:refactor-test-file-1435
Open

refactor: align test_agent_rbac with testing guide#1487
sujaan-iqbal wants to merge 2 commits into
BlazeUp-AI:mainfrom
sujaan-iqbal:refactor-test-file-1435

Conversation

@sujaan-iqbal

@sujaan-iqbal sujaan-iqbal commented Jun 21, 2026

Copy link
Copy Markdown

Purpose / Description

Refactor tests/test_agent_rbac.py to better align with the Testing Guide by improving test naming, readability, and consistency without changing behavior

Fixes

Approach

Renamed tests to use more behavior-focused names.
Added explicit return type annotations (-> None) to test methods.
Applied a consistent Arrange / Act / Assert structure.
Improved readability while preserving existing test coverage and behavior.

How Has This Been Tested?

Ran the targeted test file locally:

cd observal-server
python -m uv run pytest ../tests/test_agent_rbac.py -q

Output:
5 passed in 11.44s

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)

AI Assistance

Was generative AI tooling used to co-author this PR?

  • Yes(Please Specify the tool):
  • Was the generated code manually reviewed and tested?

@CLAassistant

CLAassistant commented Jun 21, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot added tests Pull request adds or modifies tests new contributor Pull request from a first-time contributor labels Jun 21, 2026
@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new contributor Pull request from a first-time contributor tests Pull request adds or modifies tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor existing test files to follow the Testing Guide

2 participants