refactor: align test_agent_rbac with testing guide#1487
Open
sujaan-iqbal wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Refactor tests/test_agent_rbac.py to better align with the Testing Guide by improving test naming, readability, and consistency without changing behavior
Fixes
Approach
Renamed tests to use more behavior-focused names.
Added explicit return type annotations (-> None) to test methods.
Applied a consistent Arrange / Act / Assert structure.
Improved readability while preserving existing test coverage and behavior.
How Has This Been Tested?
Ran the targeted test file locally:
cd observal-server
python -m uv run pytest ../tests/test_agent_rbac.py -q
Output:
5 passed in 11.44s
Learning (optional, can help others)
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist
Please, go through these checks before submitting the PR.
AI Assistance
Was generative AI tooling used to co-author this PR?