Skip to content

fix(users): show locked super admin roles#1518

Merged
Haz3-jolt merged 1 commit into
BlazeUp-AI:mainfrom
Haz3-jolt:fix/users-super-admin-role-select
Jun 26, 2026
Merged

fix(users): show locked super admin roles#1518
Haz3-jolt merged 1 commit into
BlazeUp-AI:mainfrom
Haz3-jolt:fix/users-super-admin-role-select

Conversation

@Haz3-jolt

@Haz3-jolt Haz3-jolt commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Purpose / Description

Admins who cannot assign the super_admin role saw super admin users as an empty role selector. This makes the users table show Super Admin and disables the picker when the current admin cannot edit that role.

Fixes

None.

Approach

  • Keep the current role as the only option when it is outside the signed in admin's assignable roles.
  • Disable the picker for uneditable roles so the existing disabled styling greys it out.
  • Preserve the existing editable role picker for roles the admin is allowed to assign.

How Has This Been Tested?

image

Learning (optional, can help others)

The existing ROLE_LABELS and PickerSelect behavior already covered the display and disabled states. The fix only needed to include the current uneditable role in the picker options.

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas.
  • You have performed a self-review of your own code.
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings).

AI Assistance

Was generative AI tooling used to co-author this PR?

  • Yes(Please Specify the tool): Pi coding agent
  • Was the generated code manually reviewed and tested?

@github-actions github-actions Bot added the web Pull request touches web frontend code label Jun 26, 2026
@Haz3-jolt Haz3-jolt merged commit 94d0ebd into BlazeUp-AI:main Jun 26, 2026
20 checks passed
@Haz3-jolt Haz3-jolt deleted the fix/users-super-admin-role-select branch June 26, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web Pull request touches web frontend code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant