Set default minimum JMeter version to 5.5 for compatibility tests#140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project's JMeter compatibility and build process to ensure support for both JMeter 5.5 (minimum) and 5.6.3 (latest). The CI pipeline is enhanced to build and test against both versions, and the code and tests are adjusted to handle version-specific differences.
CI/CD workflow improvements:
.github/workflows/ci-build.yaml: The build matrix now runs tests for both JMeter 5.5 and 5.6.3, ensuring the plugin is compatible with both versions. Artifacts are named by JMeter version for clarity. [1] [2].github/workflows/ci-jmeter-compatibility.yaml: The compatibility check now loops over both supported JMeter versions, running tests for each to verify runtime compatibility.Dependency and configuration updates:
pom.xml: The defaultjmeter.versionis updated to 5.5, and thehttpcoredependency is aligned with the version used by JMeter 5.5. [1] [2]Test improvements for JMeter version differences:
src/test/java/com/blazemeter/jmeter/http2/core/HTTP2JettyClientFileProtocolSamplingTest.java: The test for content type now dynamically determines the expected value based on the JMeter version's default encoding, ensuring the test passes on both 5.5 and 5.6.3. [1] [2]