Restore original settings on exception#141
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the reliability of tests in
HTTP2JettyClientTest.javaby ensuring that changes to thecache_manager.cached_resource_modeproperty are properly restored after each test. This prevents side effects between tests that could lead to inconsistent results.Test isolation improvements:
cache_manager.cached_resource_modeproperty inshouldNotGetSubResultWhenResourceIsCachedWithCode()andshouldNotGetSubResultWhenResourceIsCachedWithoutCode()in a try/finally block, saving and restoring the previous value to avoid side effects between tests. [1] [2] [3] [4]restoreCacheResourceModeto encapsulate the logic for restoring or removing the property as appropriate.