✨ Additional protection against a second preimage attack#67
Open
LesterEvSe wants to merge 1 commit intoBlockstreamResearch:mainfrom
Open
✨ Additional protection against a second preimage attack#67LesterEvSe wants to merge 1 commit intoBlockstreamResearch:mainfrom
LesterEvSe wants to merge 1 commit intoBlockstreamResearch:mainfrom
Conversation
…G` and `NODE_TAG`
688f1b7 to
e7f9494
Compare
Merged
|
I see "review requested" but there is no PR description or motivation or anything. |
Collaborator
Author
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comments from PR #49 have been addressed.
Mitigated Second Preimage Attacks: Introduced proper domain separation for internal hashes to ensure the structure is fully protected.
Hardcoded Unique Tags: Passed hardcoded application-specific tags (
SMT/1.0/leafandSMT/1.0/node) directly into the script, replacing the reused TapData tag.