Draft
Conversation
ivanlele
requested changes
Mar 19, 2026
service/src/handlers/sign_pset.rs
Outdated
| }) | ||
| } | ||
|
|
||
| fn sign_p2wsh( |
Collaborator
There was a problem hiding this comment.
sign_p2wsh and sign_p2sh are almost identical. We can merge them and only apply different logic where required by the type.
service/src/handlers/mod.rs
Outdated
| .with_state(signer_state) | ||
| } | ||
|
|
||
| pub enum SpendType { |
Collaborator
There was a problem hiding this comment.
You can figure out this by looking at Script.
Script::is_v0_p2wsh()
Script::is_p2sh()
Script::is_v1_p2tr()
Collaborator
There was a problem hiding this comment.
Add a parameter to the demo script that specifies the redeem script type. Run them for all 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add P2SH and P2TR transactions to service