Skip to content

Adds the cover layout control and allows a 'custom' cover (BL-15902) #7697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohnThomson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds the cover layout control and allows a 'custom' cover (BL-15902) #7697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,7 @@ The vscode terminal often loses the first character sent from copilot agents. So

# Don't run build
It is vital that you not run `yarn build` unless instructed to. If there is already a "--watch" build running, you will wreck it and waste the developer's time. You are welcome to `yarn lint` if you want to check for errors without building.

# Localization
- Localizations for translatable strings are kept in DistFiles/localizations; new ones are initially added to one of the files in the "en" subdirectory
- Mark new XLF entries translate="no"
29 changes: 29 additions & 0 deletions DistFiles/localization/en/Bloom.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1337,6 +1337,18 @@
<source xml:lang="en">Copy Page</source>
<note>ID: EditTab.CopyPage</note>
</trans-unit>
<trans-unit id="EditTab.CustomCover.Standard" translate="no">
<source xml:lang="en">Standard</source>
<note>ID: EditTab.CustomCover.Standard</note>
</trans-unit>
<trans-unit id="EditTab.CustomCover.CoverLayout" translate="no">
<source xml:lang="en">Cover Layout: </source>
<note>ID: EditTab.CustomCover.CoverLayout</note>
</trans-unit>
<trans-unit id="EditTab.CustomCover.Custom" translate="no">
<source xml:lang="en">Custom</source>
<note>ID: EditTab.CustomCover.Custom</note>
</trans-unit>
<trans-unit id="EditTab.CustomPage.ChangeLayout" sil:dynamic="true">
<source xml:lang="en">Change Layout</source>
<note>ID: EditTab.CustomPage.ChangeLayout</note>
Expand Down Expand Up @@ -2185,6 +2197,10 @@
<note>ID: EditTab.Toolbox.ComicTool.Options.BackgroundColor.OldLace</note>
<note>A background color that looks like old lace</note>
</trans-unit>
<trans-unit id="EditTab.Toolbox.ComicTool.Options.BecomeBackground" translate="no">
<source xml:lang="en">Become background</source>
<note>ID: EditTab.Toolbox.ComicTool.Options.BecomeBackground</note>
</trans-unit>
<trans-unit id="EditTab.Toolbox.ComicTool.Options.ChooseVideo" sil:dynamic="true">
<source xml:lang="en">Choose video from your computer...</source>
<note>ID: EditTab.Toolbox.ComicTool.Options.ChooseVideo</note>
Expand All @@ -2193,11 +2209,19 @@
<source xml:lang="en">Copy text</source>
<note>ID: EditTab.Toolbox.ComicTool.Options.CopyText</note>
</trans-unit>
<trans-unit id="EditTab.Toolbox.ComicTool.Options.CoverImage" sil:dynamic="true" translate ="no">
<source xml:lang="en">Cover Image</source>
<note>ID: EditTab.Toolbox.ComicTool.Options.CoverImage</note>
</trans-unit>
<trans-unit id="EditTab.Toolbox.ComicTool.Options.Duplicate" sil:dynamic="true">
<source xml:lang="en">Duplicate</source>
<note>ID: EditTab.Toolbox.ComicTool.Options.Duplicate</note>
<note>Tooltip for the bubble Duplicate icon</note>
</trans-unit>
<trans-unit id="EditTab.Toolbox.ComicTool.Options.FieldType" translate ="no">
<source xml:lang="en">Field Type:</source>
<note>ID: EditTab.Toolbox.ComicTool.Options.FieldType</note>
</trans-unit>
<trans-unit id="EditTab.Toolbox.ComicTool.Options.FillBackground" sil:dynamic="true" translate ="no">
<source xml:lang="en">Fill Background</source>
<note>ID: EditTab.Toolbox.ComicTool.Options.FillBackground</note>
Expand All @@ -2220,6 +2244,11 @@
<note>ID: EditTab.Toolbox.ComicTool.Options.OuterOutlineColor</note>
<note>Refers to the Outer Outline Color of the bubble used by the callout</note>
</trans-unit>
<trans-unit id="EditTab.Toolbox.ComicTool.Options.Language" translate="no">
<source xml:lang="en">Language:</source>
<note>ID: EditTab.Toolbox.ComicTool.Options.Language</note>
<note>Used to switch which alternative of a text overlay is shown</note>
</trans-unit>
<trans-unit id="EditTab.Toolbox.ComicTool.Options.OuterOutlineColor.None" sil:dynamic="true">
<source xml:lang="en">None</source>
<note>ID: EditTab.Toolbox.ComicTool.Options.OuterOutlineColor.None</note>
Expand Down
7 changes: 6 additions & 1 deletion src/BloomBrowserUI/bookEdit/bookSettings/FieldVisibilityGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@ import { useApiObject } from "../../utils/bloomApi";
import { useL10n } from "../../react_components/l10nHooks";
import { useMemo } from "react";

interface ILanguageNameValues {
export interface ILanguageNameValues {
language1Name: string;
language1Tag: string;
language2Name: string;
language2Tag: string;
language3Name?: string;
language3Tag?: string;
}

// This is used in BookSettingsDialog to provide a group of Config-R booleans that control
Expand Down Expand Up @@ -40,7 +43,9 @@ export const FieldVisibilityGroup: React.FunctionComponent<{
const languageNameValues: ILanguageNameValues =
useApiObject<ILanguageNameValues>("settings/languageNames", {
language1Name: "",
language1Tag: "",
language2Name: "",
language2Tag: "",
});
const showWrittenLanguage1TitleLabel = useL10n(
props.labelFrame,
Expand Down
Loading