Convert the thumbnail context menu to display in React (BL-15895)#7702
Convert the thumbnail context menu to display in React (BL-15895)#7702StephenMcConnel wants to merge 1 commit intomasterfrom
Conversation
@StephenMcConnel would it be more natural for the UI (typescript) to know the menu items it wants? |
StephenMcConnel
left a comment
There was a problem hiding this comment.
I thought about it but came up with two reasons for keeping the way the AI structured things:
- There would need to be an API call for each menu item to get its localized label.
- There would need to be an API call for each menu item to get its enabled state, although maybe that could be computed on the client side. I haven't really looked at that.
Making a single API call to get all of the menu items with those values already computed seemed like a reasonable choice with
simpler setup.
@StephenMcConnel made 1 comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved.
hatton
left a comment
There was a problem hiding this comment.
Yeah, let's "go native" for all of these menus, not rely on the server to act like part of the UI. We have UI all over in typescript land that manages to localize itself one way or the other :-)
@hatton made 1 comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved.
StephenMcConnel
left a comment
There was a problem hiding this comment.
OK.
@StephenMcConnel made 1 comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved.
This change is