Skip to content

Feature/friendslistanddietoptions#110

Open
freddiet803 wants to merge 9 commits intomasterfrom
feature/friendslistanddietoptions
Open

Feature/friendslistanddietoptions#110
freddiet803 wants to merge 9 commits intomasterfrom
feature/friendslistanddietoptions

Conversation

@freddiet803
Copy link
Copy Markdown
Contributor

Description

Adding the delete a saved promotion feature.
still need to tweak testing
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Change Status

  • Complete, but not tested (may need new tests)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code has been reviewed by at least one peer
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • There are no merge conflicts

@Jeffreyo3
Copy link
Copy Markdown
Contributor

The button of the last promo on the list is not visible on mobile if there are more than 2 promotions saved.

@freddiet803
Copy link
Copy Markdown
Contributor Author

freddiet803 commented Jun 25, 2020

I didn't style for mobile, slipped my mind... but i will take a look at it! thanks jeff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants